iop parsing: make the PictureGraphic data size check less restricitve #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martonmiklos
force-pushed
the
fix_picture_size_check
branch
3 times, most recently
from
8a7fe7b to
f2ff899
Compare
martonmiklos
changed the title
I came across an implement (Kverneland Andex1304) which contains a PictureGraphics with 0x0 actual size and 0 raw data size. Later it contains the same PictureGraphics object with correct dimensions, but the parser bailed out on the first zero size.
martonmiklos
force-pushed
the
fix_picture_size_check
branch
from
f2ff899 to
c02843d
Compare
|
Hi folks, I have no idea about the source of the CI failure, the unit tests are passed here locally: |
GwnDaan
approved these changes
Jan 8, 2025
|
Yeah some unit tests are a bit unpredictable, they occasionaly throw an error. I reran the tests and now it passes... |
GwnDaan
added
bug
ad3154
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across an implement (Kverneland Andex1304) which contains a PictureGraphics with 0x0 actual size and 0 raw data size. Later in the pool it contains the same PictureGraphics object with correct dimensions, but the parser bailed out on the first zero size.
Fixes martonmiklos/AgIsoVirtualTerminal#2
How has this been tested?
Built AgIsoVt with this commit an the Kverneland Andex1304 loads fine.